INTERLIS Export - invalid TID with *_Text classes

[sjib]

Label export option selected - gives invalid tid's - Postfix is too long e.g. ch080txtPR000028353, postfix should be only 8 characters long ch080txtPR028353

Info: validate data...
Info: assume unknown external objects
Info: first validation pass...
Error: line 5: DSS_2020_1_LV95.Siedlungsentwaesserung.Haltung_Text: tid ch080txtPR000028353: value <ch080txtPR000028353> is not a valid OID
Error: line 6: DSS_2020_1_LV95.Siedlungsentwaesserung.Haltung_Text: tid ch080txtPR000028354: value <ch080txtPR000028354> is not a valid OID
Error: line 7: DSS_2020_1_LV95.Siedlungsentwaesserung.Haltung_Text: tid ch080txtPR000028355: value <ch080txtPR000028355> is not a valid OID
Error: line 8: DSS_2020_1_LV95.Siedlungsentwaesserung.Haltung_Text: tid ch080txtPR000028356: value <ch080txtPR000028356> is not a valid OID
Error: line 9: DSS_2020_1_LV95.Siedlungsentwaesserung.Haltung_Text: tid ch080txtPR000028357: value <ch080txtPR000028357> is not a valid OID
Error: line 10: DSS_2020_1_LV95.Siedlungsentwaesserung.Haltung_Text: tid ch080txtPR000028358: value <ch080txtPR000028358> is not a valid OID
Error: line 11: DSS_2020_1_LV95.Siedlungsentwaesserung.Haltung_Text: tid ch080txtPR000028359: value <ch080txtPR000028359> is not a valid OID
Error: line 12: DSS_2020_1_LV95.Siedlungsentwaesserung.Haltung_Text: tid ch080txtPR000028360: value <ch080txtPR000028360> is not a valid OID
Error: line 13: DSS_2020_1_LV95.Siedlungsentwaesserung.Haltung_Text: tid ch080txtPR000028361: value <ch080txtPR000028361> is not a valid OID
Error: line 14: DSS_2020_1_LV95.Siedlungsentwaesserung.Haltung_Text: tid ch080txtPR000028362: value <ch080txtPR000028362> is not a valid OID
Error: line 15: DSS_2020_1_LV95.Siedlungsentwaesserung.Haltung_Text: tid ch080txtPR000028363: value <ch080txtPR000028363> is not a valid OID
Error: line 16: DSS_2020_1_LV95.Siedlungsentwaesserung.Haltung_Text: tid ch080txtPR000028364: value <ch080txtPR000028364> is not a valid OID
Error: line 17: DSS_2020_1_LV95.Siedlungsentwaesserung.Haltung_Text: tid ch080txtPR000028365: value <ch080txtPR000028365> is not a valid OID
Error: line 18: DSS_2020_1_LV95.Siedlungsentwaesserung.Haltung_Text: tid ch080txtPR000028366: value <ch080txtPR000028366> is not a valid OID
Error: line 19: DSS_2020_1_LV95.Siedlungsentwaesserung.Haltung_Text: tid ch080txtPR000028367: value <ch080txtPR000028367> is not a valid OID

...

Error: line 2056: DSS_2020_1_LV95.Siedlungsentwaesserung.Abwasserbauwerk_Text: tid ch080txtPR000030045: value <ch080txtPR000030045> is not a valid OID
Error: line 2057: DSS_2020_1_LV95.Siedlungsentwaesserung.Abwasserbauwerk_Text: tid ch080txtPR000030046: value <ch080txtPR000030046> is not a valid OID
Error: line 2058: DSS_2020_1_LV95.Siedlungsentwaesserung.Abwasserbauwerk_Text: tid ch080txtPR000030047: value <ch080txtPR000030047> is not a valid OID
Error: line 2059: DSS_2020_1_LV95.Siedlungsentwaesserung.Abwasserbauwerk_Text: tid ch080txtPR000030048: value <ch080txtPR000030048> is not a valid OID
Error: line 2060: DSS_2020_1_LV95.Siedlungsentwaesserung.Abwasserbauwerk_Text: tid ch080txtPR000030049: value <ch080txtPR000030049> is not a valid OID
Error: line 2061: DSS_2020_1_LV95.Siedlungsentwaesserung.Abwasserbauwerk_Text: tid ch080txtPR000030050: value <ch080txtPR000030050> is not a valid OID

[sjib]

@domi4484 Please check about this.

Also add warning when more than 999999 labels per *_text class!

Then we have to think of another solution - but a warning would be good for the moment to get a hint, if this case happens.

[sjib]

I think it could be this line that needs to be adapted:

wastewater/plugin/teksi_wastewater/interlis/interlis_model_mapping/interlis_exporter_to_intermediate_schema.py

Line 2522 in c148d7b

"t_ili_tid": f"ch080txtPR0000{t_id}",

Also please use the shortcut_en for the respective _text classes as defined in the datamodel: WX, RX and CX instead of PR

        "t_ili_tid": f"ch080txt**PR**0000{t_id}",

[sjib]

@urskaufmann @ponceta @cymed @Elwiss - do we want a hard-coded prefix (as it is currently) or should the active one from the table oid_prefixes be used? What are the requirements in AG64/96?

[sjib]

@ponceta Can you comment on the fix?

[domi4484]

Is it ok to just log a warning in case of more than 999999 labels or should we either show an error message and stop?

[sjib]

I think a warning is ok for now, so that we see what is happening.
For a next release we can start thinking about a solution if we have members where this warning starts showing up.

[cymed]

@urskaufmann @ponceta @cymed @Elwiss - do we want a hard-coded prefix (as it is currently) or should the active one from the table oid_prefixes be used? What are the requirements in AG64/96?

AG-64/AG-96 only requires t_id=t_ili_tid, regardless of the OID that is used. In the current project definition (V0.2), we supposed that table oid_prefixes is used, but it is no must.