Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Fallback function to read External Pod Specs just like what we did for external log #2323

Closed
TianxiangShen opened this issue Mar 11, 2022 · 3 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@TianxiangShen
Copy link
Contributor

Is your feature request related to a problem ?

Hi Community, I recent setup a external log server to provide logs when original logs are not available. But I noticed in most cases when pod logs are missing, the Pod's Specs are also missing (maybe due to the pod is deleted). Since now Tekton dashboard can only fetch external Logs, I think it's better to add a method to fetch External Pod Specs because sometimes Pod Specs can be really useful when debugging a taskrun/pipelinerun failure. (for example, we missconfigure the args of a container)

Describe the solution you'd like

As similar to ExternalLogsURL, we can add a fallback function useExternalPodURL when the original function usePod failed to get the pod specs.

Describe alternatives you've considered

Additional context

@TianxiangShen TianxiangShen added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 11, 2022
@AlanGreene
Copy link
Member

Thanks for the feature request @TianxiangShen. The external logs support is still experimental and subject to change, so any future integration of external sources may not take the same form as the logs solution and there are other considerations in terms of caching, client processing, etc. that are not applicable to logs in the same manner.

Right now I would be reluctant to start adding support for loading individual resource types from some other external source as this could quickly become unmanageable, both in terms of the code/maintenance overhead in the Dashboard and ensuring correct authentication/authorization on the part of the provider(s).

For long-term storage of non-log resources we're most likely going to leverage Tekton Results. Integration between Results and Dashboard is being tracked in tektoncd/results#82 and is on the roadmap.

@TianxiangShen
Copy link
Contributor Author

Thanks for the reply, I remember Tekton Results doesn't support Pod's Specs storage right, please correct me if I'm wrong.

@AlanGreene
Copy link
Member

Apologies for the delay. That is correct, Tekton Results currently stores only TaskRuns and PipelineRuns.

Closing this issue for now as we're not planning to add specialised external storage of other resources to the Dashboard in the near future. We may revisit again as Tekton Results evolves or as other solutions become available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants