Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run web project tests in PR job #90

Closed
steveodonovan opened this issue Apr 26, 2019 · 5 comments
Closed

Run web project tests in PR job #90

steveodonovan opened this issue Apr 26, 2019 · 5 comments
Assignees

Comments

@steveodonovan
Copy link
Member

The pull request job does not run/report status for npm tests.

npm run test:ci

Similarly lint rules are not applied.

@AlanGreene
Copy link
Member

As a start we should run:

npm ci # similar to `npm install` but ensures all versions from lock file
npm run test:ci

It would also be good to:

npm run build # will also fail on lint errors

@a-roberts a-roberts self-assigned this May 3, 2019
@a-roberts a-roberts mentioned this issue May 3, 2019
2 tasks
@a-roberts
Copy link
Member

PR for this is here, stuck from progressing and details in the PR. I could just be one word away from being done with it (assuming no test failures), depends on what @vdemeester says (I think out for the RedHat summit atm).

@a-roberts
Copy link
Member

Actually I'm running in a container with just our code, and I'm root in it, so I've continued.

https://prow.tekton.dev/log?job=pull-tekton-dashboard-tests&id=1124292059839074304 check it out.

I0503 12:39:22.797] Test Suites: 30 passed, 30 total
I0503 12:39:22.797] Tests:       157 passed, 157 total
I0503 12:39:22.797] Snapshots:   0 total
I0503 12:39:22.797] Time:        11.523s
I0503 12:39:22.797] Ran all test suites.

@a-roberts
Copy link
Member

@vdemeester please take a look at how I'm using Prow, the tests run and pass but perhaps there's a neater way to install things?

@a-roberts
Copy link
Member

Kindly merged and reviewed now by Alan, discussed on Slack (more details on the PR) about eventually using our own image for tests with deps in, and made an issue for that at #116.

Closing 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants