-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run web project tests in PR job #90
Comments
As a start we should run: npm ci # similar to `npm install` but ensures all versions from lock file
npm run test:ci It would also be good to: npm run build # will also fail on lint errors |
PR for this is here, stuck from progressing and details in the PR. I could just be one word away from being done with it (assuming no test failures), depends on what @vdemeester says (I think out for the RedHat summit atm). |
Actually I'm running in a container with just our code, and I'm root in it, so I've continued. https://prow.tekton.dev/log?job=pull-tekton-dashboard-tests&id=1124292059839074304 check it out.
|
@vdemeester please take a look at how I'm using Prow, the tests run and pass but perhaps there's a neater way to install things? |
Kindly merged and reviewed now by Alan, discussed on Slack (more details on the PR) about eventually using our own image for tests with deps in, and made an issue for that at #116. Closing 😄 |
The pull request job does not run/report status for npm tests.
npm run test:ci
Similarly lint rules are not applied.
The text was updated successfully, but these errors were encountered: