Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle build/taskrun timeout outside of resync #456

Closed
vdemeester opened this issue Jan 30, 2019 · 5 comments · Fixed by #621
Closed

Handle build/taskrun timeout outside of resync #456

vdemeester opened this issue Jan 30, 2019 · 5 comments · Fixed by #621
Assignees
Labels
design This task is about creating and discussing a design help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug.

Comments

@vdemeester
Copy link
Member

Capturing discussion over Slack, knative/build#543 breaks our timeout handling, because we rely on the resync to enforce timeouts. build-pipeline rely on the same for timeouts (or will with #355).

The reason to change the resync time is the following

Resyncing every 30s seems to lead us to hit rate limits that we never recover from when there are too many builds in the system at a given time. Serving also switched to resyncing every 10h for similar scaling reasons.

We need to rely on something else for build/taskrun timeouts, running a background goroutine in the controller, watching builds instead could be an option (we'll need to handle the case where the controller pod restarts, …)

/cc @imjasonh @bobcatfish @shashwathi @abayer

@bobcatfish bobcatfish added the kind/bug Categorizes issue or PR as related to a bug. label Feb 6, 2019
@bobcatfish bobcatfish added this to the Moar features for 0.1 milestone Feb 6, 2019
@bobcatfish bobcatfish added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. design This task is about creating and discussing a design labels Feb 6, 2019
@bobcatfish bobcatfish removed this from the Moar features for 0.1 milestone Feb 8, 2019
@nader-ziada
Copy link
Member

@bobcatfish I think this should be part of the 0.2 milestone as we discussed

@vdemeester
Copy link
Member Author

/assign

@vdemeester
Copy link
Member Author

/assign @shashwathi

@shashwathi
Copy link
Contributor

/assign @shashwathi

@vdemeester
Copy link
Member Author

/assign @shashwathi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design This task is about creating and discussing a design help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
4 participants