Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move internal functions into internal packages #5679

Open
lbernick opened this issue Oct 24, 2022 · 3 comments
Open

Move internal functions into internal packages #5679

lbernick opened this issue Oct 24, 2022 · 3 comments
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@lbernick
Copy link
Member

Based on this discussion thread.
Everything in the apis packages and the client packages should be public, and all other code should be moved into the internal folder where possible to avoid usage outside of the repo and reduce our Go API surface.

@vdemeester
Copy link
Member

Everything in the apis packages and the client packages should be public, and all other code should be moved into the internal folder where possible to avoid usage outside of the repo and reduce our Go API surface.

Note that today, other tektoncd component might depend on those, for example the cli, or the operator, or triggers or even chains. I think for each package we want to move we need to see if it make sense or not to be "public" (and exported) or not.

See #5681 (review)

@tekton-robot
Copy link
Collaborator

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 23, 2023
@vdemeester
Copy link
Member

/lifecycle frozen

@tekton-robot tekton-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 23, 2023
@lbernick lbernick removed their assignment Mar 27, 2023
@lbernick lbernick changed the title Move non-API related code into internal Move internal functions into internal packages Jun 6, 2023
@lbernick lbernick added this to the Pipeline v1.0.0 milestone Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
Status: Todo
Development

No branches or pull requests

3 participants