Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup isRunRetriable in the release v0.47.0 #5870

Closed
Tracked by #5810
XinruZhang opened this issue Dec 12, 2022 · 5 comments · Fixed by #6508
Closed
Tracked by #5810

Cleanup isRunRetriable in the release v0.47.0 #5870

XinruZhang opened this issue Dec 12, 2022 · 5 comments · Fixed by #6508
Assignees
@Yongxuanzhang
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Milestone
Pipelines v0.47

Comments

@XinruZhang
Copy link
Member

XinruZhang commented Dec 12, 2022 •
edited
Loading

In the release v0.47.0, we plan to fully remove the support for v1alpha1.Run as proposed in TEP-0114.

isRunRetriable exists only to support the retries function in v1alpha1.Run. Therefore we need to clean that function up after fully deprecating v1alpha1.Run in the release v0.47.0.

Related issue: #5837, #5810
@XinruZhang XinruZhang mentioned this issue Dec 12, 2022
Closed
1 task
@jerop jerop added this to the Pipelines v0.47 milestone Dec 13, 2022
@jerop
Copy link
Member

jerop commented Dec 13, 2022

/kind cleanup

@tekton-robot tekton-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Dec 13, 2022
@XinruZhang XinruZhang changed the title Cleanup isCustomTaskRetriable in the release v0.47.0 Cleanup isRunRetriable in the release v0.47.0 Dec 15, 2022
This was referenced Dec 21, 2022
Merged
Closed
@tekton-robot
Copy link
Collaborator

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 15, 2023
@pritidesai
Copy link
Member

@XinruZhang are we good with the current milestone on this one? thanks!

@XinruZhang
Copy link
Member Author

Thank you @pritidesai, yes we need this one in the current milestone, will do

@Yongxuanzhang
Copy link
Member

/assign

@Yongxuanzhang Yongxuanzhang mentioned this issue Apr 5, 2023
Closed
@lbernick lbernick removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 6, 2023
@lbernick lbernick mentioned this issue Apr 7, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Yongxuanzhang Yongxuanzhang

Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
Tekton Community Roadmap
Status: Done
Milestone
Pipelines v0.47
Development

Successfully merging a pull request may close this issue.

TEP-0114: Remove support for v1alpha1.Run lbernick/pipeline
6 participants
@pritidesai @jerop @lbernick @XinruZhang @Yongxuanzhang @tekton-robot