Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle v1beta1.taskObject interface and v1beta1.pipelineObject interface for V1 as the storage version #5979

Closed
2 tasks
JeromeJu opened this issue Jan 10, 2023 · 6 comments
Assignees
Labels
kind/misc Categorizes issue or PR as a miscellaneuous one.

Comments

@JeromeJu
Copy link
Member

JeromeJu commented Jan 10, 2023

Since the storage version is going to be swapped to v1, and there are no existing v1 task_interface.go and pipeline_interface.go. We need to either remove the interfaces or to separate them from the versioned packages in pkg/apis/pipeline/v1beta1.

Related with v1 release of swapping the storage version, subtask of #5541

@JeromeJu JeromeJu changed the title Handle TaskObject and PipelineObject in task_interface and pipeline_interface Handle task_interface and pipeline_interface for V1 as the storage version Jan 10, 2023
@JeromeJu JeromeJu changed the title Handle task_interface and pipeline_interface for V1 as the storage version Handle task_interface and pipeline_interface for V1 as the storage version Jan 10, 2023
@JeromeJu
Copy link
Member Author

JeromeJu commented Jan 10, 2023

Due to the amount of work for removing task_interface.go and pipeline_interface.go entirely from the codebase, I would go for the route that we move them out of the versioned package.

Also trying to figure out if there is an existing way I can take to circumvent duplicating the efforts of handling this now and its later removal.

@tekton-robot tekton-robot added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Jan 10, 2023
@lbernick lbernick moved this to In Progress in Pipelines V1 Jan 18, 2023
@JeromeJu
Copy link
Member Author

This comment is to update the progress on this issue:

@JeromeJu
Copy link
Member Author

Also similar at https://github.com/tektoncd/pipeline/blob/main/pkg/trustedresources/verify.go#L49
cc @Yongxuanzhang could we swap the verification to v1.Task?

@Yongxuanzhang
Copy link
Member

Yongxuanzhang commented Mar 28, 2023

https://github.com/tektoncd/pipeline/blob/main/pkg/trustedresources/verify.go#L49

Yes that would be great. I think supporting v1 task and pipeline is what we want

@JeromeJu JeromeJu changed the title Handle task_interface and pipeline_interface for V1 as the storage version Handle v1beta1.taskObject interface and v1beta1.pipelineObject interface for V1 as the storage version Mar 30, 2023
@JeromeJu
Copy link
Member Author

For v1beta1.pipelineObject interface, after searching through the codebase, there doesn't seem to be ClusterPipeline in place. Opening a PR to replace all v1beta1.pipelineObject to v1beta1.pipeline.

@lbernick
Copy link
Member

lbernick commented Apr 3, 2023

Closed by #6469 and #6471

@lbernick lbernick closed this as completed Apr 3, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Pipelines V1 Apr 3, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in Tekton Community Roadmap Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/misc Categorizes issue or PR as a miscellaneuous one.
Projects
Status: Done
Status: Done
Development

No branches or pull requests

4 participants