-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle v1beta1.taskObject
interface and v1beta1.pipelineObject
interface for V1
as the storage version
#5979
Comments
task_interface
and pipeline_interface
for V1
as the storage version
Due to the amount of work for removing task_interface.go and pipeline_interface.go entirely from the codebase, I would go for the route that we move them out of the versioned package. Also trying to figure out if there is an existing way I can take to circumvent duplicating the efforts of handling this now and its later removal. |
This comment is to update the progress on this issue:
|
Also similar at https://github.com/tektoncd/pipeline/blob/main/pkg/trustedresources/verify.go#L49 |
Yes that would be great. I think supporting v1 task and pipeline is what we want |
task_interface
and pipeline_interface
for V1
as the storage versionv1beta1.taskObject
interface and v1beta1.pipelineObject
interface for V1
as the storage version
For |
Since the storage version is going to be swapped to v1, and there are no existing v1 task_interface.go and pipeline_interface.go. We need to either remove the interfaces or to separate them from the versioned packages in
pkg/apis/pipeline/v1beta1
.Remove the task_interface.go and pipeline_interface.go
Move the task_interface.go and pipeline_interface.go out of the versioned package.
Related with v1 release of swapping the storage version, subtask of #5541
The text was updated successfully, but these errors were encountered: