Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate ResourcesResult with the removal of PipelineResources #6325

Closed
JeromeJu opened this issue Mar 8, 2023 · 1 comment
Closed

Deprecate ResourcesResult with the removal of PipelineResources #6325

JeromeJu opened this issue Mar 8, 2023 · 1 comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Comments

@JeromeJu
Copy link
Member

JeromeJu commented Mar 8, 2023

taskrun.status.resourcesresult was introduced for writing PipelineResourcesResults from images digest since created. Now that PipelineResources are removed, we should deprecate the field.

Also reasons why it should be removed in details:

  • ResourceResult, according its description, was 'Results from Resources built during the TaskRun. currently includes the digest of build container images', now since image resources are removed, it was left meaningless.
  • ResourceResult highly relies on PipelineResourcesResult type, where previously PipelineResourceResult is being written to it, now that PipelineResources is being removed, there is no usage for resourcesResult
  • ResourceResult has not been moved to v1, when we swap the storage versions, there will not be a suitable place to write to PipelineResourceResult any more

/kind cleanup

@tekton-robot tekton-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Mar 8, 2023
@lbernick
Copy link
Member

Closed by #6301

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Development

No branches or pull requests

3 participants