Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metadata to pipelinerun to capture the complete pipeline definition #994

Closed
siamaksade opened this issue Jun 20, 2019 · 3 comments
Closed
Labels
area/api Indicates an issue or PR that deals with the API. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@siamaksade
Copy link

siamaksade commented Jun 20, 2019

It's currently impossible to reason on the exact pipeline definition, conditions, git and image urls used when a pipelinerun is executed given that pipelinerun includes references to pipeline, condition and pipeline resources which all can change after pipeline execution is complete.

This is specially difficult for building tooling around Tekton, for example causing graph visualisation of a completed pipelinerun change when the referenced pipeline is modified.

Adding metadata to the pipelinerun including the exact pipeline, conditions, and resources would allow to capture the exact state of the pipelinerun which won't change even if those referenced resources change. This can be done for example via adding annotations to PipelineRun

pipelinerun.tekton.dev/pipeline-configuration
pipelinerun.tekton.dev/pipelineresource-configuration
pipelinerun.tekton.dev/condition-configuration

An example of this is Helm Releases which embed the generated manifests from the Helm Chart inside the Helm Release to capture the exact resource definitions that are associated with a particular Helm Release, instead of referring to the chart given that the chart can change after the release was created.

@vdemeester vdemeester added area/api Indicates an issue or PR that deals with the API. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. labels Jun 20, 2019
@vdemeester
Copy link
Member

This is also kinda related to @afrittoli comment on #859 on how do we manage pipeline reference of a PipelineRun when the Pipeline changes (after the run)

What happens when a PR that modifies the task/pipeline definition is merged? The desired behaviour would be that any running tasks/pipelines keep running on the old definition and any new task/pipeline uses the new definition. However if the new definition is applied to the cluster this would affect in-flight tasks/pipelines.

@siamaksade siamaksade changed the title When PipelineRun fails, it doesn't include the complete execution plan Add metadata to pipelinerun to capture the complete pipeline definition Mar 6, 2020
@siamaksade
Copy link
Author

@vdemeester I have updated this issue to better capture the need

@vdemeester
Copy link
Member

This is closed by #2489 and #2444

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api Indicates an issue or PR that deals with the API. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants