Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiline comment break the /test [ci-job-name] command for Tekton based jobs #626

Open
Tracked by #912
afrittoli opened this issue Nov 2, 2020 · 4 comments
Open
Tracked by #912
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@afrittoli
Copy link
Member

Expected Behavior

I can enter a multi-line comment in GitHub that includes /test [ci-job-name] by itself on one line

Actual Behavior

Multi-line comment breaks the logic of the check condition:

  # If no command was specified, the check is successful
  [[ "$(inputs.params.gitHubCommand)" == "" ]] && exit 0

Steps to Reproduce the Problem

  1. Leave a multi-line comment on an issue that includes /test
  2. Observe the condition logs
  3. https://dashboard.dogfooding.tekton.dev/#/namespaces/tektonci/taskruns/tekton-yamllint-x9cm5-lint-cg6gj-check-name-matches-1-77fm4?step=condition-check-check-name-matches&view=logs
https://dashboard.dogfooding.tekton.dev/#/namespaces/tektonci/taskruns/tekton-yamllint-x9cm5-lint-cg6gj-check-name-matches-1-77fm4?step=condition-check-check-name-matches&view=logs

Additional Info

@afrittoli
Copy link
Member Author

/kind bug

@tekton-robot tekton-robot added the kind/bug Categorizes issue or PR as related to a bug. label Nov 2, 2020
@afrittoli afrittoli added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Nov 2, 2020
@tekton-robot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 31, 2021
@vdemeester
Copy link
Member

/lifecycle frozen
We need to handle that case

@tekton-robot tekton-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 4, 2021
@afrittoli
Copy link
Member Author

We do! Honestly, I'd love to have a CELRun based solution and remove that condition for good :)

@afrittoli afrittoli added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
Status: Todo
Status: Todo
Development

No branches or pull requests

3 participants