fix: Ensure type column in information_schema views is not null #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekumara
reviewed
Aug 3, 2024
tekumara
changed the title
tekumara
pushed a commit
that referenced
this pull request
Aug 4, 2024
🤖 I have created a release *beep* *boop* --- ## [0.9.21](v0.9.20...v0.9.21) (2024-08-04) ### Features * alter table cluster by ([9a78fc2](9a78fc2)) ### Bug Fixes * Allow connection with schema=information_schema ([#122](#122)) ([51e4e68](51e4e68)) * columns returned by describe view information_schema.columns ([83c62b6](83c62b6)) * Ensure type column in information_schema views is not null ([#121](#121)) ([7340a4a](7340a4a)) * Only set variables for SetItem expressions ([#116](#116)) ([0e0711c](0e0711c)) ### Chores * bump sqlglot 25.5.1 ([713d93d](713d93d)) * cruft update ([72b791b](72b791b)) * **deps-dev:** bump pyright from 1.1.369 to 1.1.374 ([#118](#118)) ([17a8760](17a8760)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: potatobot-prime[bot] <132267321+potatobot-prime[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this when trying to use snowflake-sqlalchemy to test view creation using fakesnow. It's actually sort of also a bug in snowflake-sqlalchemy, that it's hitting an untested code path and failing. but also, this column should have a type, and adding one avoids the latent bug in snowflake-sqlalchemy.