Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notice: Compataibility issues with RxJS 6.3.x #1962

Closed
tsvetomir opened this issue Dec 3, 2018 · 1 comment
Closed

Notice: Compataibility issues with RxJS 6.3.x #1962

tsvetomir opened this issue Dec 3, 2018 · 1 comment

Comments

@tsvetomir
Copy link
Member

Symptoms

Starting with v6.3.0 of rxjs and rxjs-compat, you may experience run-time errors or incorrect behavior. These are caused by failing instanceof checks for Observable due to ReactiveX/rxjs#4070

For example, the Grid - Confirmation Dialog on Row Removal sample will not work. Many other scenarios could also be affected.

Workaround

There are two suggested workarounds:

A) Override TypeScript compiler options

Use the approach suggested by @s25g5d4 in the upstream issue.
Add the path section below to compilerOptions in src/tsconfig.app.json:

{
    "compilerOptions": {
        "paths": {
            "rxjs/internal/Observable": [
                "../node_modules/rxjs/_esm5/internal/Observable"
            ]
        }
    }
}

B) Pin RxJS version at 6.2.x

You can lock your application to the unaffected 6.2.x version of rxjs by issuing the following command:

npm install --save rxjs@6.2 rxjs-compat@6.2

Solution

We're considering the possibilities for a permanent fix and will post updates.

@tsvetomir tsvetomir pinned this issue Dec 14, 2018
@dimitar-pechev dimitar-pechev unpinned this issue Dec 15, 2018
@tsvetomir tsvetomir pinned this issue Dec 18, 2018
@Raisolution Raisolution unpinned this issue Dec 19, 2018
@Raisolution Raisolution pinned this issue Dec 19, 2018
@tsvetomir
Copy link
Member Author

tsvetomir commented Feb 4, 2019

Fixed in rxjs v6.4.0 with ReactiveX/rxjs#4070.
Please note that current versions of rxjs require TypeScript 2.8 or later.

@tsvetomir tsvetomir unpinned this issue Feb 4, 2019
@tsvetomir tsvetomir pinned this issue Feb 4, 2019
@tsvetomir tsvetomir unpinned this issue May 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant