Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@progress/kendo-angular-charts 4.1.5 -> error on prod #2966

Closed
meriturva opened this issue Jun 25, 2020 · 7 comments
Closed

@progress/kendo-angular-charts 4.1.5 -> error on prod #2966

meriturva opened this issue Jun 25, 2020 · 7 comments
Assignees

Comments

@meriturva
Copy link

Updating all packages to latest version (still on angular 9.1.11) i found that package @progress/kendo-angular-charts 4.1.5 on prod throws error:

main.3f436b464a06d00d92da.js:1 Uncaught TypeError: Cannot read property 'dateFormats' of undefined
at Module.zUnb (main.3f436b464a06d00d92da.js:1)
at i (runtime.c532273e4f1e83dd741c.js:1)
at Object.0 (main.3f436b464a06d00d92da.js:1)
at i (runtime.c532273e4f1e83dd741c.js:1)
at t (runtime.c532273e4f1e83dd741c.js:1)
at Array.r [as push] (runtime.c532273e4f1e83dd741c.js:1)
at main.3f436b464a06d00d92da.js:1

With version 4.1.4 there is no such problem.

Ticket 1473464 on telerik support

@tsvetomir
Copy link
Member

Thanks for reporting, I've managed to reproduce the issue. It's an odd one because the code that throws the error hasn't been modified for quite a while.

@meriturva
Copy link
Author

In fact, I have another project quite old that now even with version 4.1.4 throws error on prod.
Do you have a version number without that issue? Just to run tests on it

@tsvetomir
Copy link
Member

Fixed in @progress/kendo-charts v1.14.2 and @progress/kendo-drawing v1.8.1.
That explains why changing the @progress/kendo-angular-charts version was not effective.

Running npm update should update these depdendencies.
If that fails, remove node_modules, package-lock.json and re-install.

@meriturva
Copy link
Author

I will give it a try as soon as possible

@juanslingerURUIT
Copy link

Hi, @tsvetomir thanks for the answer.

From Kendo angular chart documentation (https://www.telerik.com/kendo-angular-ui/components/charts/get-started/) I'm seeing @progress/kendo-drawing as a dependency but not @progress/kendo-charts.

Do the documentation needs to be updated?
I'm testing in our production mode this solution

@meriturva
Copy link
Author

Ok it works... I forgot to update the lock file on CI.
Now seems ok.

@tsvetomir
Copy link
Member

@juanslingerURUIT The "kendo-charts" package is a direct dependency and is not listed together with the peers.

To make sure that everyone gets the update, we've released v4.1.6 of @progress/kendo-angular-charts that explicitly references the fixed version.

Sorry for the trouble!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants