Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid requests are still counted for the IP daily limit #260

Open
sakibarifin opened this issue Jan 26, 2023 · 0 comments
Open

Invalid requests are still counted for the IP daily limit #260

sakibarifin opened this issue Jan 26, 2023 · 0 comments
Labels
🐛 Bug Something isn't working

Comments

@sakibarifin
Copy link

sakibarifin commented Jan 26, 2023

If a user inputs data in wrong format to the faucet form, it assumes the user has received faucet funds even though that is false. So, the faucet forces people to wait 24 hours if they make a single typo and enter the address incorrectly. It neither sends the funds nor allows the user to submit the form correctly again to receive funds as the timer is triggered even if the user didn't receive any testnet tokens.

  • same issue for when testnet account creation fails

Telos testnet faucet bug

This issue can be fixed by adding input validation mentioned in #259

@karynemayer karynemayer changed the title Bug in telos testnet faucet page Invalid requests are still counted for the IP daily limit Feb 15, 2023
@karynemayer karynemayer added the 🐛 Bug Something isn't working label Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants