Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Antlib Refactor | make store dependencies clear #745

Open
Viterbo opened this issue Jan 9, 2024 · 0 comments
Open

Antlib Refactor | make store dependencies clear #745

Viterbo opened this issue Jan 9, 2024 · 0 comments

Comments

@Viterbo
Copy link
Collaborator

Viterbo commented Jan 9, 2024

Description

To prepare the Antlib for its own project, we must first clean the code as much as we can, refactoring all working code that is not written in the best way. This issue lists a few observations that may be addressed to have a cleaner code.

Proposed enhancements

  • The AntelopeConfig object must be defined in a separate file (src/antelope/config/AntelopeConfig.ts) rather than in the index.ts
  • Change the imports in the file src/antelope/index.ts. All the useXYZStore functions must be imported from the complete path and not from itself.
  • Fix stores dependencies
    • Chan: should not depend on Contract or Account
    • Contract: should not depend on Account
    • EVM: should not depend on Account
    • Account: should not depend on Balances, Allowances, History or Nfts
@Viterbo Viterbo self-assigned this Jan 9, 2024
@Viterbo Viterbo mentioned this issue Jan 9, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant