Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global transaction watcher (toast, notifications) #106

Closed
poplexity opened this issue Aug 15, 2022 · 0 comments · Fixed by #466
Closed

Global transaction watcher (toast, notifications) #106

poplexity opened this issue Aug 15, 2022 · 0 comments · Fixed by #466
Assignees
Labels
✨ Enhancement Improvements on existing features

Comments

@poplexity
Copy link
Member

poplexity commented Aug 15, 2022

Overview

There would be many opportunities to improve user experience if there were a global system for monitoring the status of a transaction triggered by the UI

Acceptance criteria

  • when the user stakes or claims unstaked s/tlos, a toast notification should be displayed saying what happened, eg. "Staked 1 TLOS for .3 sTLOS completed"
  • functions invoked from the function interfaces in the contract tab, eg. here, should pop a toast when the transaction is completed

Technical considerations

A global api which is given a transaction hash and other data, it then polls for the transaction to be executed and renders a toast to the user, and calls a callback from the component.

Possibly this could be integrated into a centralized "sendTransaction" function.

Data to pass into it:

Name: "sTLOS staking"
Completion message: "Staked 1 TLOS for .3 sTLOS completed"
Callback: function from sTLOS page that would reload balances

  • when transactions initiated by the UI are completed, a toast should be displayed to the user
  • there should also be the ability to trigger a callback, or possibly a singleton pub/sub pattern, to allow components to react to the completion of a transaction
  • this solution should gracefully handle multiple transactions, showing toasts in succession when multiple complete in overlapping timeframes

Tasks

@poplexity poplexity added the ✨ Enhancement Improvements on existing features label Aug 15, 2022
@ezra-sg ezra-sg added 🔬 Needs Refinement Further information is required and removed 🔬 Needs Refinement Further information is required labels Oct 9, 2022
@pmjanus pmjanus changed the title Global transaction watcher Global transaction watcher (toast, notifications) Oct 20, 2023
@Viterbo Viterbo self-assigned this Oct 20, 2023
@Viterbo Viterbo linked a pull request Oct 25, 2023 that will close this issue
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Enhancement Improvements on existing features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants