Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct upstream connection closing #2280

Open
const-t opened this issue Nov 15, 2024 · 0 comments
Open

Correct upstream connection closing #2280

const-t opened this issue Nov 15, 2024 · 0 comments

Comments

@const-t
Copy link
Contributor

const-t commented Nov 15, 2024

Commit ef12112

Looking this code I can assume following behavior: When error occurred, Tempesta sends error response, however if at this moment new segment will be received it will be passed to tfw_connection_recv() and again to tfw_http_resp_process() that not expected at this moment. Seems here we should mark connection as Conn_Stop.

Need to develop the new test for this issue. The test:

  1. Send 3 requests from 3 different clients.
  2. Prepare 3 pretty large responses. First one invalid, for instance with invalid header.
  3. Send 1 byte segmented response to Tempesta.
  4. Check the first client received valid response and that connections with another two clients was closed.

Also case T_BLOCK in this place looks strange, because tfw_http_parse_resp() must doesn't return T_BLOCK. Please check it out.

@const-t const-t added this to the 0.9 - LA milestone Nov 15, 2024
@const-t const-t added the bug label Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant