Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Connections to the database cannot be closed #872

Open
innocenzi opened this issue Dec 24, 2024 · 1 comment · May be fixed by #875
Open

[Bug]: Connections to the database cannot be closed #872

innocenzi opened this issue Dec 24, 2024 · 1 comment · May be fixed by #875
Labels
Database Feature Request Request a feature that is not currently in the framework.

Comments

@innocenzi
Copy link
Member

innocenzi commented Dec 24, 2024

In PHP, we cannot manually close a PDO connection. All references to the PDO instance must be garbage-collected in order to close the connection.

Internally, Tempest passes the PDO object around in multiple classes (Database, TransactionManager and PdoInitializer). We would need to wrap it so we can close connections manually.

@innocenzi innocenzi added Bug Something isn't working Triage New issues that need to be reviewed by the Tempest team. Database and removed Triage New issues that need to be reviewed by the Tempest team. labels Dec 24, 2024
@blackshadev
Copy link
Contributor

I am unsure if the label "bug" is applicable. But I created a PR which should help your efforts in #857 .

@innocenzi innocenzi added Feature Request Request a feature that is not currently in the framework. and removed Bug Something isn't working labels Dec 29, 2024
@brendt brendt added this to the v1.0.0-alpha.5 milestone Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Database Feature Request Request a feature that is not currently in the framework.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants