Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Field missing in Astroid plugin to enter Gmaps key. #858

Closed
felixkat opened this issue Nov 1, 2024 · 2 comments · Fixed by #853
Closed

Field missing in Astroid plugin to enter Gmaps key. #858

felixkat opened this issue Nov 1, 2024 · 2 comments · Fixed by #853
Assignees
Labels
bug Something isn't working
Milestone

Comments

@felixkat
Copy link

felixkat commented Nov 1, 2024

Widget Google Maps looks for an API Key if selecting advanced.

$gmap_api = $pluginParams->get('gmap_api', '');

But the field is missing in the Astroid plugin.

Also errors in the console log, (even with key hard coded).

image

@sonvnn
Copy link
Member

sonvnn commented Nov 5, 2024

@felixkat Thank you for report issue. I fixed this issue at d28e568

Please help me download v3-branch and test it.

@sonvnn sonvnn added this to the Version 3.1.8 milestone Nov 5, 2024
@sonvnn sonvnn added the bug Something isn't working label Nov 5, 2024
@sonvnn sonvnn self-assigned this Nov 5, 2024
@sonvnn sonvnn moved this to In review in Astroid Framework Nov 5, 2024
@felixkat
Copy link
Author

felixkat commented Nov 5, 2024

The new field is tested and working.

Strangely though, the advanced map only works when Minify JS is enabled.

image

If Minify JS is disabled it only works 5% of the time

image

@sonvnn sonvnn linked a pull request Nov 22, 2024 that will close this issue
@github-project-automation github-project-automation bot moved this from In review to Done in Astroid Framework Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants