Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Honor all non-terminal commands #778

Closed
dandavison opened this issue Jul 13, 2024 · 0 comments · Fixed by #776
Closed

Honor all non-terminal commands #778

dandavison opened this issue Jul 13, 2024 · 0 comments · Fixed by #776
Labels
enhancement New feature or request

Comments

@dandavison
Copy link
Contributor

See temporalio/features#481

Today, core truncates the command sequence sent by lang at the first "terminal" (i.e. workflow-completing) command.

We will change this behavior to instead honor all non-terminal commands, i.e. even when in the command sequence sent by lang they are preceded by a terminal command. In practice, this means moving any terminal commands to the end of the sequence. If there are multiple terminal commands, core will truncate at the first, i.e. respecting the order sent by lang.

The primary motivation for this change is to honor update completions when they occur in the same workflow task as workflow completions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant