Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR 1404 breaks workflowcheck #1405

Closed
aaomidi opened this issue Feb 29, 2024 · 3 comments
Closed

PR 1404 breaks workflowcheck #1405

aaomidi opened this issue Feb 29, 2024 · 3 comments

Comments

@aaomidi
Copy link

aaomidi commented Feb 29, 2024

          This PR breaks workflow check.
workflowcheck ./...
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
        panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x2 addr=0x0 pc=0x104880200]

goroutine 1015 [running]:
go/types.(*Checker).handleBailout(0x140022fa200, 0x14002407b98)
        /nix/store/2022s0jnrn2iyxjaikfy51w5fvifp38b-go-1.22.0/share/go/src/go/types/check.go:367 +0x9c
panic({0x104a82be0?, 0x104c9fde0?})
        /nix/store/2022s0jnrn2iyxjaikfy51w5fvifp38b-go-1.22.0/share/go/src/runtime/panic.go:770 +0x124

Originally posted by @aaomidi in #1403 (comment)

Made a new issue for visibility since I know closed PRs sometimes don't send notifications

@cretz
Copy link
Member

cretz commented Feb 29, 2024

This looks like #1382, can you confirm it is because of #1403? Can you try workflowcheck from master and see if it still occurs?

@Quinn-With-Two-Ns
Copy link
Contributor

Pulling the latest workflow check

samples-go git:(async-update-sample) ✗ go install go.temporal.io/sdk/contrib/tools/workflowcheck@master           
go: downloading go.temporal.io/sdk/contrib/tools/workflowcheck v0.1.1-0.20240229191239-d9a574d4ffa4
go: downloading go.temporal.io/sdk v1.26.0-rc.3.0.20240229191239-d9a574d4ffa4

and running in samples gave no error so I suspect it is #1382

@aaomidi
Copy link
Author

aaomidi commented Feb 29, 2024

Ooops, looks like initially go pulled the wrong versions for me. Sorry master works fine!

@aaomidi aaomidi closed this as completed Feb 29, 2024
@cretz cretz closed this as not planned Won't fix, can't repro, duplicate, stale Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants