Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot set really short max heartbeat throttle interval #859

Closed
cretz opened this issue Jul 20, 2022 · 0 comments · Fixed by #863
Closed

Cannot set really short max heartbeat throttle interval #859

cretz opened this issue Jul 20, 2022 · 0 comments · Fixed by #863
Labels
potential-bug

Comments

@cretz
Copy link
Member

cretz commented Jul 20, 2022

Expected Behavior

Expect to be able to set this to, like, 1 nanosecond and it work

Actual Behavior

For whatever reason in #660, I put context.WithTimeout(ctx, i.heartbeatThrottleInterval) which means that context times out immediately
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
potential-bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support really short heartbeat throttling interval cretz/temporal-sdk-go
1 participant
@cretz