-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lazy connectivity for Temporal client and healthCheck #224
Comments
The SDK healthcheck goes though the already open client on RR side. A.k.a. it should aready work as expected and not create any excessive connections. |
Does PHP client support lazy and eager creation? We have all of that in the other SDKs. |
Not at the moment. We also don't have @roxblnfk We will work on RFC based on temporalio/features#45 |
With the release of 2.7.0, interceptor functionality will be introduced. Along with this, the This interceptor is not added by default, but we can do this - add |
Regarding gRPC HealthCheck - it's not supported by the PHP gRPC extension. |
@bergundy do we expect HealthCheck mostly in Activity and WF pollers or client code as well? We do have health checks for all the pollers, but PHP does not have a BG check mechanism for clients. |
In other languages we have a lazy method to create a connection (client) that doesn't make any calls to the server, and an eager connection method that fails if That's all I requested in this issue. |
Eager connect on demand (lazy) - done (in fact in PHP this is the default way how GRPC works) I think we are good there. |
SDK should have a lazy and eager way to create a client and expose a healthcheck method
ref: #223
The text was updated successfully, but these errors were encountered: