Skip to content

Commit 510aaf4

Browse files
committed
fix exit code and slack notification steps
1 parent 4c15d70 commit 510aaf4

File tree

1 file changed

+9
-8
lines changed

1 file changed

+9
-8
lines changed

.github/workflows/nightly-throughput-stress.yml

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,9 @@ on:
44
schedule:
55
# Run at 3 AM PST (11:00 UTC) - offset from existing nightly
66
- cron: '00 11 * * *'
7+
push:
8+
branches:
9+
- nightly_tps
710
workflow_dispatch:
811
inputs:
912
duration:
@@ -135,9 +138,8 @@ jobs:
135138
136139
- name: Run throughput stress scenario with local SDK
137140
working-directory: omes
141+
continue-on-error: true
138142
run: |
139-
set +e # Don't fail immediately on error
140-
141143
# Use run-scenario-with-worker to build and run in one step
142144
# Pass the SDK directory as --version for local testing
143145
# Note: The hardcoded values below match OMES defaults, except:
@@ -146,7 +148,7 @@ jobs:
146148
go run ./cmd run-scenario-with-worker \
147149
--scenario throughput_stress \
148150
--language typescript \
149-
--version $(pwd)/../sdk-typescript \
151+
--version $(pwd)/.. \
150152
--run-id $RUN_ID \
151153
--duration $TEST_DURATION \
152154
--timeout $TEST_TIMEOUT \
@@ -158,22 +160,21 @@ jobs:
158160
--option min-throughput-per-hour=1000 \
159161
2>&1 | tee $WORKER_LOG_DIR/scenario.log
160162
161-
SCENARIO_EXIT_CODE=$?
162-
echo "SCENARIO_EXIT_CODE=$SCENARIO_EXIT_CODE" >> $GITHUB_ENV
163-
exit $SCENARIO_EXIT_CODE
163+
echo "SCENARIO_EXIT_CODE=${PIPESTATUS[0]}" >> $GITHUB_ENV
164164
165165
- name: Upload logs on failure
166-
if: failure()
166+
if: env.SCENARIO_EXIT_CODE != '0'
167167
uses: actions/upload-artifact@v4
168168
with:
169169
name: throughput-stress-logs
170170
path: ${{ env.WORKER_LOG_DIR }}
171171
retention-days: 30
172172

173173
- name: Notify Slack on failure
174-
if: failure()
174+
if: env.SCENARIO_EXIT_CODE != '0'
175175
uses: slackapi/slack-github-action@v2
176176
with:
177+
webhook-type: incoming-webhook
177178
payload: |
178179
{
179180
"text": "Nightly TypeScript throughput stress test failed",

0 commit comments

Comments
 (0)