fix: fix multiple issues that were causing CI flakes (#1394)

Author: mjameswh

.vscode/settings.json

@@ -1,3 +1,4 @@
 {
-  "temporal.replayerEntrypoint": "packages/test/src/debug-replayer.ts"
+  "temporal.replayerEntrypoint": "packages/test/src/debug-replayer.ts",
+  "rust-analyzer.linkedProjects": ["./packages/core-bridge/Cargo.toml"]
 }

packages/core-bridge/Cargo.lock

@@ -82,11 +82,12 @@ function compile(requestedTarget) {
   const cmd = which.sync('cargo-cp-artifact');
 
   console.log('Running', cmd, argv);
-  const { status } = spawnSync(cmd, argv, {
+  const { status, error } = spawnSync(cmd, argv, {
     stdio: 'inherit',
+    shell: process.platform === 'win32',
   });
-  if (status !== 0) {
-    throw new Error(`Failed to build${target ? ' for ' + target : ''}`);
+  if (status !== 0 || error) {
+    throw new Error(`Failed to build${target ? ' for ' + target : ''}: status code ${status}`, error);
   }
 }
 

packages/core-bridge/scripts/build.js

@@ -4,6 +4,7 @@ use std::{
     cell::{Cell, RefCell},
     collections::HashMap,
     ops::Deref,
+    process::Stdio,
     sync::Arc,
     time::{Duration, SystemTime, UNIX_EPOCH},
 };
@@ -299,11 +300,15 @@ pub fn start_bridge_loop(
                     callback,
                 } => {
                     core_runtime.tokio_handle().spawn(async move {
+                        let stdout = Stdio::from(std::io::stdout());
+                        let stderr = Stdio::from(std::io::stderr());
                         let result = match config {
                             EphemeralServerConfig::TestServer(config) => {
-                                config.start_server().await
+                                config.start_server_with_output(stdout, stderr).await
+                            }
+                            EphemeralServerConfig::DevServer(config) => {
+                                config.start_server_with_output(stdout, stderr).await
                             }
-                            EphemeralServerConfig::DevServer(config) => config.start_server().await,
                         };
                         match result {
                             Err(err) => {

packages/core-bridge/sdk-core

@@ -20,13 +20,15 @@ interface InstallArgs {
  * @returns A Promise that resolves once the installation is finished.
  */
 export function install({ root, useYarn }: InstallArgs): Promise<void> {
-  const npm = /^win/.test(process.platform) ? 'npm.cmd' : 'npm';
+  const isWindows = process.platform === 'win32';
+  const npm = isWindows ? 'npm.cmd' : 'npm';
   const command: string = useYarn ? 'yarn' : npm;
 
   return spawn(command, ['install'], {
     cwd: root,
     stdio: 'inherit',
     env: { ...process.env, ADBLOCK: '1', DISABLE_OPENCOLLECTIVE: '1' },
+    shell: isWindows,
   });
 }
 

packages/core-bridge/src/runtime.rs

@@ -21,7 +21,7 @@ import {
 } from '@temporalio/worker';
 import * as workflow from '@temporalio/workflow';
 import { ConnectionInjectorInterceptor } from './activities/interceptors';
-import { Worker, test as anyTest, bundlerOptions } from './helpers';
+import { Worker, test as anyTest, bundlerOptions, registerDefaultCustomSearchAttributes } from './helpers';
 
 export interface Context {
   env: TestWorkflowEnvironment;
@@ -59,6 +59,7 @@ export function makeTestFunction(opts: {
         ],
       },
     });
+    await registerDefaultCustomSearchAttributes(env.connection);
     const workflowBundle = await bundleWorkflowCode({
       ...bundlerOptions,
       workflowInterceptorModules: [...defaultWorkflowInterceptorModules, ...(opts.workflowInterceptorModules ?? [])],

packages/create-project/src/helpers/install.ts

@@ -423,7 +423,7 @@ test('No 10s delay on close due to grpc-js', async (t) => {
       }
     });
     const duration = Date.now() - startTime;
-    t.true(duration < 2000, `Expected duration to be less than 2s, got ${duration / 1000}s`);
+    t.true(duration < 5000, `Expected duration to be less than 5s, got ${duration / 1000}s`);
   } finally {
     server.forceShutdown();
   }

packages/test/src/helpers-integration.ts

@@ -153,12 +153,12 @@ test('HistorySize is visible in WorkflowExecutionInfo', async (t) => {
 
 export async function suggestedCAN(): Promise<boolean> {
   const maxEvents = 40_000;
-  const batchSize = 100;
+  const batchSize = 1000;
   if (workflow.workflowInfo().continueAsNewSuggested) {
     return false;
   }
   while (workflow.workflowInfo().historyLength < maxEvents) {
-    await Promise.all(new Array(batchSize).fill(undefined).map((_) => workflow.sleep(1)));
+    await Promise.all(Array.from({ length: batchSize }, (_) => workflow.sleep(1)));
     if (workflow.workflowInfo().continueAsNewSuggested) {
       return true;
     }

packages/test/src/test-client-connection.ts

@@ -1,4 +1,3 @@
-const path = require('path');
 const { spawn: spawnChild, spawnSync } = require('child_process');
 const arg = require('arg');
 const { shell, kill } = require('./utils');

packages/test/src/test-integration-workflows.ts

@@ -9,6 +9,9 @@ class ChildProcessError extends Error {
   }
 }
 
+const shell = /^win/.test(process.platform);
+const sleep = (ms) => new Promise((resolve) => setTimeout(resolve, ms));
+
 async function waitOnChild(child) {
   return new Promise((resolve, reject) => {
     child.on('exit', (code, signal) => {
@@ -44,10 +47,7 @@ async function kill(child, signal = 'SIGINT') {
 async function spawnNpx(args, opts) {
   const npx = /^win/.test(process.platform) ? 'npx.cmd' : 'npx';
   const npxArgs = ['--prefer-offline', '--timing=true', '--yes', '--', ...args];
-  await waitOnChild(spawn(npx, npxArgs, opts));
+  await waitOnChild(spawn(npx, npxArgs, { ...opts, shell }));
 }
 
-const shell = /^win/.test(process.platform);
-const sleep = (ms) => new Promise((resolve) => setTimeout(resolve, ms));
-
 module.exports = { kill, spawnNpx, ChildProcessError, shell, sleep };