Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eagerly validate and put proper metadata on search attributes for on schedule workflow action #4787

Closed
cretz opened this issue Aug 21, 2023 · 0 comments
Labels
enhancement New feature or request schedules

Comments

@cretz
Copy link
Member

cretz commented Aug 21, 2023

Describe the solution you'd like

Today all setting of search attributes is eagerly validated and is guaranteed when retrieved from the server to have the type metadata set, except for the search attributes set on the workflow of a schedule (not to be confused with search attributes of the schedule itself). We need to bring search attributes on workflows of schedules in line w/ all others with regards to validation and metadata.

Please make sure the backwards-incompatibility ramifications are taken into account. If we eagerly validate search attributes where we didn't before, someone's automated process that creates a schedule with a future workflow and then creates search attributes is now going to fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request schedules
Projects
None yet
Development

No branches or pull requests

2 participants