Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintroduce zigzag encoding via tag #239

Open
2 tasks
liamsi opened this issue Oct 26, 2018 · 1 comment
Open
2 tasks

Reintroduce zigzag encoding via tag #239

liamsi opened this issue Oct 26, 2018 · 1 comment

Comments

@liamsi
Copy link
Contributor

liamsi commented Oct 26, 2018

As per #238 ints, int32s, and int64s aren't zigzag encoded by default. Add a tag such that developers can still zigzag encode. If they need to encode ints which often contain negative numbers this is more efficient.

TODOs:

Zigzag encoding is used in proto3 for encoding sint(32|64).
References:

@liamsi
Copy link
Contributor Author

liamsi commented Jun 5, 2019

removed from the proto milestone: My understanding is, we require everything amino encodes can be represented as a protobuf message and not that amino supports every proto feature.

@liamsi liamsi removed this from the Full Proto compatibility milestone Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants