You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
good point @rickyyangz. Did you you re-benchmark with your suggested changes? I would assume the performance to still be much slower than generated protobuf.
While looking into adding amino to this list: https://github.com/alecthomas/go_serialization_benchmarks (see this branch: https://github.com/Liamsi/go_serialization_benchmarks/tree/add_amino), it seems like amino is quite slow compared to other similar libraries:
Hopefully, we should be able to vastly improve this performance without completely reworking the structure.
Here is what the profiler tells us about memory/cpu while running above benchmarks for unmarshaling/marshaling:
Zaki suggested to add a hint in the readme about performance issue and in which cases users would might want to refrain from using amino.
The text was updated successfully, but these errors were encountered: