Make MarshalBinary the non-length prefixed default #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- and have a MarshalBinaryLengthPrefixed instead
liamsi
added a commit
to liamsi/cosmos-sdk
that referenced
this pull request
Sep 4, 2018
5 tasks
liamsi
changed the title
liamsi
changed the title
liamsi
added a commit
to tendermint/tendermint
that referenced
this pull request
Sep 8, 2018
liamsi
added a commit
to liamsi/cosmos-sdk
that referenced
this pull request
Sep 8, 2018
liamsi
changed the title
Merged
This was referenced Oct 22, 2018
ebuchman
pushed a commit
to tendermint/tendermint
that referenced
this pull request
Oct 25, 2018
* catch up with amino changes in tendermint/go-amino#222 * WIP: update to amino v0.13.0 * update to fixed amino release
liamsi
added a commit
to liamsi/cosmos-sdk
that referenced
this pull request
Oct 29, 2018
- initially this was also renamed but we decided to do this in an incremental, two step approach (see discussion: tendermint/go-amino#222)
kfangw
pushed a commit
to kfangw/blockchain
that referenced
this pull request
Jun 10, 2019
* catch up with amino changes in tendermint/go-amino#222 * WIP: update to amino v0.13.0 * update to fixed amino release
NexZhu
pushed a commit
to crpt/go-merkle
that referenced
this pull request
Dec 1, 2021
* catch up with amino changes in tendermint/go-amino#222 * WIP: update to amino v0.13.0 * update to fixed amino release
cmwaters
pushed a commit
to celestiaorg/go-square
that referenced
this pull request
Dec 19, 2023
* catch up with amino changes in tendermint/go-amino#222 * WIP: update to amino v0.13.0 * update to fixed amino release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #219
as per discussion with @jaekwon I've added back the WIP in the title:I think the 2 steps approach works fine; keeping marshalbinarybare is simpler but less explicit (which the default is).
Currently, this PR only does the marshalbinary -> marshalbinarylengthprefixed step as explained above.