This repository has been archived by the owner on Jun 3, 2020. It is now read-only.
tmkms.toml: Make [validator.addr] a URL #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change simplifies the configuration file by collapsing the large "connection" section of the configuration down to individual URLs which use the same syntax as in gaia.
tarcieri
force-pushed
the
simplify-config
branch
from
1420d28 to
625ab58
Compare
tony-iqlusion
commented
Nov 20, 2018
| use error::{KmsError, KmsErrorKind::*}; | ||
|
|
||
| #[derive(Clone, Debug)] | ||
| pub enum ValidatorAddr { |
There was a problem hiding this comment.
This type is arguably useful as an address for more things than just validators, and could potentially go in the tendermint crate.
tony-iqlusion
commented
Nov 20, 2018
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change simplifies the configuration file by collapsing the large "connection" section of the configuration down to individual URLs which use the same syntax as in gaia, i.e. the
[validator.addr]should be the same as gaiad'spriv_validator_laddr