Skip to content
This repository has been archived by the owner on Jun 3, 2020. It is now read-only.

import 32-byte seed instead of 64-byte key-pair #113

Merged
merged 1 commit into from
Nov 23, 2018

Conversation

liamsi
Copy link
Contributor

@liamsi liamsi commented Nov 23, 2018

fix #112

Copy link
Contributor

@tarcieri tarcieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to add a test for this. Offhand I can't remember why I didn't write one for generate...

@liamsi
Copy link
Contributor Author

liamsi commented Nov 23, 2018

I'll open an issue for adding test in a separate PR (for import and the other commands).

Offhand I can't remember why I didn't write one for generate...

I just didn't add a test because there were none for generate and I assumed that the yubihsm might be non-trivial to mock.

@liamsi liamsi merged commit 5de45fb into master Nov 23, 2018
@liamsi liamsi deleted the 112_fix_yubihsm_import branch November 23, 2018 20:05
@tarcieri
Copy link
Contributor

tarcieri commented Nov 23, 2018

I assumed that the yubihsm might be non-trivial to mock.

It is, but it's already been done:

https://docs.rs/yubihsm/latest/yubihsm/mockhsm/struct.MockHsm.html

...and the mock HSM will be automatically used in the tests when you enable the yubihsm-mock cargo feature:

https://github.com/tendermint/kms/blob/master/Cargo.toml#L47
https://github.com/tendermint/kms/blob/master/src/yubihsm.rs#L59

@tarcieri tarcieri mentioned this pull request Nov 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error running tmkms yubihsm keys import
2 participants