This repository has been archived by the owner on Jun 3, 2020. It is now read-only.
Remove PoisonPillMsg #162
Merged
Remove PoisonPillMsg #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use kill instead of wait, integration tests will block anyways until proper replies are received
thanethomson
approved these changes
Jan 23, 2019
|
Nice |
@thanethomson, I played around with the libc idea before I removed it again: Although, this works (all tests pass and won't block forever), we see some errors in the logs. Maybe that's OK though. I've did not include this change because of the errors in the logs and the additional dependency. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #161 we have other means to shut down gracefully.
Note that that integration tests currently use
SIGKILLto shut down the processes they've started. I couldn't find a way to send SIGINT in rust without adding another (dev) dependency. If we want an integration test for the sig_hook, or, let the tests use SIGINT (ctrl+c) instead of SIGKILL, we can do so by usinglibcI think.