Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Most operation simulation fails in campaign for some specific seed #716

Open
lumtis opened this issue Apr 13, 2022 · 1 comment
Open

Most operation simulation fails in campaign for some specific seed #716

lumtis opened this issue Apr 13, 2022 · 1 comment
Labels
campaign Related to campaign module test Improve tests

Comments

@lumtis
Copy link
Contributor

lumtis commented Apr 13, 2022

When using seed = 50 for simulation testing, this is the result we get for campaign:

"campaign": {
  "add_shares": {
   "failure": 23
  },
  "add_vesting_options": {
   "failure": 34,
   "ok": 3
  },
  "burn_vouchers": {
   "failure": 32
  },
  "create_campaign": {
   "failure": 31,
   "ok": 6
  },
  "initialize_mainnet": {
   "failure": 7
  },
  "mint_vouchers": {
   "failure": 36
  },
  "redeem_vouchers": {
   "failure": 37
  },
  "send": {
   "failure": 36
  },
  "unredeem_vouchers": {
   "failure": 34
  },
  "update_total_supply": {
   "failure": 6
  }
 }

I think that for some seed, the initialization, the initial creation of campaigns will create a state where our method GetCoordSimAccount or GetCoordSimAccountWithCampaignID are always unable to retrieve a coordinator or a campaign.

If this is the reason we should try to make these retriever methods more resilient.

This is not a high-priority since we can have good simulation results with other seeds

@giunatale
Copy link
Contributor

Yes, I think your assumption is correct. Perhaps this ties to the way we handle simulation in profile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
campaign Related to campaign module test Improve tests
Projects
None yet
Development

No branches or pull requests

2 participants