fix: fix reset commands #8270
Merged
fix: fix reset commands #8270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderbez
requested review from
ebuchman,
cmwaters,
tychoish,
williambanfield and
creachadair
as code owners
creachadair
reviewed
Apr 7, 2022
| } | ||
|
|
||
| // XXX: this is totally unsafe. | ||
| // it's only suitable for testnets. | ||
| func resetPrivValidator(cmd *cobra.Command, args []string) { | ||
| func resetPrivValidator(cmd *cobra.Command, args []string) (err error) { | ||
| config, err = ParseConfig() |
There was a problem hiding this comment.
I don't see resetFilePV relying on the global config value, so I'm not certain I see why we need to parse into the global var here.
There was a problem hiding this comment.
Huh? It literally calls resetFilePV with the values from config below.
There was a problem hiding this comment.
Yea, it uses the values from the variable as set here. I'm confused as to why we don't just use a local variable here for the return of ParseConfig instead of binding its result to the package-global config variable seeing as resetFilePV does not use fields from the global config variable as far as I can tell. I.e., it gets the values through args not by referencing global scope.
19 tasks
creachadair
approved these changes
Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream consumers of Tendermint's commands that use them directly as opposed to using the
rootcommand will fail becauseconfigis a private global. This forces the upstream user to manually parse the config or having each command do it. This PR takes the latter approach.