Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in linking resources folders of components when they have a different interface name #24

Closed
furkan3ayraktar opened this issue Nov 18, 2018 · 0 comments
Assignees
Labels

Comments

@furkan3ayraktar
Copy link
Collaborator

Describe the bug
PR #21 causes tests failing after merging fixes to tests in PR #18. The reason of this is delete command does not delete the right resources folder, which is named with the interface name. Also same PR introduced another bug where if you create a new component with a different interface, it links the wrong resources folder to the system. This results in a bad behavior in remove command as well.

To Reproduce
Steps to reproduce the behavior:

  1. create s system-1 base-1
  2. create c component-1 interface-1
  3. add component-1 system-1
  4. Check resources folder under system-1. You'll see a wrong symbolic link with component name.
  5. delete c component-1
  6. Check resources folder under development environment. You'll see a broken symbolic link to interface-1

Expected behavior
System should have correct resources folder linked.
Development environment shouldn't have symbolic link.

Operating System (please complete the following information):

  • OS: MacOS
  • Version: 10.14

Versions (please complete the following information):

  • Leiningen: 2.8.1
  • Java: 1.8.0_181
  • Polylith: 0.2.0 (master branch version)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant