discussion(errors): Use github.com/cockroachdb/errors instead of pkg/errors

[gaocegege]

Description

#14 (comment)

IMO, the crucial use of pkg/error is it implements the method Unwrap, and thus we can use errors.Is to see if two errors are the same.

But pkg/error is in the maintain mode, should we use this one instead?

[gaocegege]

/cc @Thrimbda

Are you interested in fixing it? Or I will work on it soon.

[gaocegege]

the crucial use of pkg/error is it implements the method Unwrap

Actually the builtin fmt.Errorf could do the same thing, please see also https://pkg.go.dev/errors#Unwrap.

As for me, the advantage of using github.com/pkg/errors is we could see the call stack, which is not supported by fmt.Errorf("%w").

Personally prefer github.com/pkg/errors since it provides many wrappers and helper functions.

My two cents is that we could provide an internal package with the similar API using fmt.Errorf if we are not interested in the call stack and do not want to risk ourselves using a not maintained Go module.

From @knight42

[gaocegege]

Yeah, I think the main advantage is the stack. We may need it since we have a frontend language starlark, and stack trace is what we need to print the error when there is a language error.

[Thrimbda]

Are you interested in fixing it? Or I will work on it soon.

You mean to replace pkg/errors with the package I mentioned?

Anyway, I am interested in doing the work.

[gaocegege]

You mean to replace pkg/errors with the package I mentioned?

Yeah. Thanks!