Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: synchronous remote index dropping #340

Closed
3 tasks
usamoi opened this issue Feb 4, 2024 · 0 comments · Fixed by #414
Closed
3 tasks

feat: synchronous remote index dropping #340

usamoi opened this issue Feb 4, 2024 · 0 comments · Fixed by #414

Comments

@usamoi
Copy link
Collaborator

usamoi commented Feb 4, 2024

Remote index dropping is asynchronous: the command successes immediately but there will be an error if the handle number is reused by PostgreSQL.

  • implement synchronous remote index dropping; related to feat: refactor async task executor #260
  • pgvecto.rs uses relNode for remote handle to make reindex concurrently work, but it should use tenant id (32 bits, always set to 0 for now), unique system identifier (64 bits) and oid (32 bits) for remote handle
  • use object_access_hook to drop remote indexes, which is more reliable (the dropping implementation does not work for temporary relations and crashed transactions, so it's bad)

Reading materials for contributor:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant