Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create TFA OSS Usage Analyzer #236

Closed
seanpmorgan opened this issue May 6, 2019 · 11 comments
Closed

Create TFA OSS Usage Analyzer #236

seanpmorgan opened this issue May 6, 2019 · 11 comments
Labels
discussion needed help wanted Needs help as a contribution

Comments

@seanpmorgan
Copy link
Member

We've been using the TF contrib analyzer provided by @kingspp in order to triage components of tf.contrib to be moved to Addons:
https://tf-contrib-analyzer.herokuapp.com/
https://github.com/kingspp/tf-contrib-analyzer

Per our charter... we'll need to analyze the usage of Addons as part of our periodic review process. As part of a fork we may want to add some changes to improve the accuracy and push them upstream. The first one that comes to mind is to ignore .rst and .md files which are more than likely false positives.

cc @dynamicwebpaige as this was discussed in the Monthly meeting and there may be interest in setting this up for all of TensorFlow if applicable.

@seanpmorgan seanpmorgan added help wanted Needs help as a contribution discussion needed labels May 6, 2019
@kingspp
Copy link

kingspp commented May 7, 2019

Let me know where I can help.

@WindQAQ
Copy link
Member

WindQAQ commented Jun 19, 2019

@seanpmorgan Hi Sean, is this still active?

@seanpmorgan
Copy link
Member Author

Hey Tzu-Wei. Yeah... still active but not a priority. I don't think we'll be gauging OSS adoption until ~6months after TF2 release.

@WindQAQ
Copy link
Member

WindQAQ commented Jun 19, 2019

Sure, thanks for the clarification 😃

@bhack
Copy link
Contributor

bhack commented Mar 31, 2020

@seanpmorgan It is not the contrib project resurrection but I have a quick script to make a rought count of tensorflow_addons repos on github:
https://gist.github.com/bhack/885b79e57a6c4a59f1b1e5e12df74884

We have used by Github counter that check only requirements.txt that is at 191 now.
The script code search instead count a Total Repos: 363 (without filters like addons repo itself etc..)

@bhack
Copy link
Contributor

bhack commented Mar 31, 2020

I've another stub for an histogram sampling in the first 100 repositories:
https://gist.github.com/bhack/5fb3d721a995a672a236f1eede016340

plot

@seanpmorgan
Copy link
Member Author

seanpmorgan commented Apr 2, 2020

I've another stub for an histogram sampling in the first 100 repositories:
https://gist.github.com/bhack/5fb3d721a995a672a236f1eede016340

Awesome thanks @bhack this is very useful. We're also interested in what addons have no usage as well to help us determine if there are bugs/implementation problems, duplicated code on different repos, etc.

Thanks a bit trickier to do but certainly useful

@bhack
Copy link
Contributor

bhack commented Apr 2, 2020

We're also interested in what addons have no usage as well to help us determine if there are bugs/implementation problems, duplicated code on different repos, etc.

What do you mean?

@seanpmorgan
Copy link
Member Author

As in which specific addons modules are / are not being used.

@bhack
Copy link
Contributor

bhack commented Apr 2, 2020

Yes no usage it is quite hard to define for pattern matching. For this subtopic I am mainly interested in the Google brain/TF perimeters as you know we could to achieve an important policy enforcing goal. It is hard in these days to find refence impl of non Google papers in Tensorflow so at least having Google Research/Brain/TF team itself contributing in addon could help on the points that you have exposed.
See edge cases of non use like this tensorflow/io#839 (comment) (a Google paper, no official impl, many Pytorch impl, not finalizend in addons, implemented in TF by Mozilla on third party repo etc..)

@seanpmorgan
Copy link
Member Author

TensorFlow Addons is transitioning to a minimal maintenance and release mode. New features will not be added to this repository. For more information, please see our public messaging on this decision:
TensorFlow Addons Wind Down

Please consider sending feature requests / contributions to other repositories in the TF community with a similar charters to TFA:
Keras
Keras-CV
Keras-NLP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion needed help wanted Needs help as a contribution
Projects
None yet
Development

No branches or pull requests

4 participants