Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DenseNets in Tensorflow #8278

Closed
Eshan-Agarwal opened this issue Mar 13, 2020 · 11 comments
Closed

DenseNets in Tensorflow #8278

Eshan-Agarwal opened this issue Mar 13, 2020 · 11 comments
Assignees
Labels
models:official models that come under official repository type:community request Requests from the community type:feature

Comments

@Eshan-Agarwal
Copy link

Is TensorFlow have DenseNet architecture like others ResNet etc. Can I add DenseNet architecture in Tensorflow/Models. I previously worked on it. Or just load it using keras as TF supports keras.

@Eshan-Agarwal Eshan-Agarwal added models:official models that come under official repository type:feature labels Mar 13, 2020
@saberkun
Copy link
Member

Hi Eshan-Agarwal,
Because DenseNet is inside keras.application and users may just need add some regularization to train a keras.application model, it does not look like an important model to re-implement.
Here is an example: https://github.com/tensorflow/models/blob/master/official/vision/image_classification/resnet_imagenet_main.py#L191
We do not have plan to add DenseNet at this moment.

@Eshan-Agarwal
Copy link
Author

@saberkun Thanks and okay.

@bhack
Copy link
Contributor

bhack commented Mar 17, 2020

@Eshan-Agarwal If you are interested ina a Tensorflow2 impl https://github.com/okason97/DenseNet-Tensorflow2 /cc @okason97

@Eshan-Agarwal
Copy link
Author

@bhack thank you so much it will help.

@srilman
Copy link

srilman commented Apr 16, 2020

Not to be rude @saberkun, but the reasoning that "keras.applications has DenseNet so there's no need to reimplement it" seems like a pretty weak argument. ResNet and ResNet_v2 are both implemented in keras.applications but tensorflow/models also has an implementation which IMO is more flexible but not as easy to use.

To be fair, ResNets are much more popular than DenseNets. But at the same time, I do think a more flexible version of DenseNets (as well as less popular models) would be useful for people who have more varied use cases. For example, one could not just use the DenseNet provided in Keras directly to train for CIFAR, even though the original paper does (because the first couple of layers are different).

BTW, would be happy to contribute if its OK!

@saberkun
Copy link
Member

saberkun commented May 7, 2020

Hi @srilman, the official models cost more to maintain. We are in progress to build general vision modeling libraries. I think it would be chance to have DenseNet empowered by the library as we also want to bridge the existing object detection and slim model zoo.

Defer to @jaeyounkim for the detailed plan.
Right now, we establish the community folder. If there is a very good DenseNet TF repository, we could review and recommend it.

@jaeyounkim jaeyounkim added the type:community request Requests from the community label May 13, 2020
@jaeyounkim
Copy link
Collaborator

@srilman I've added a "community suggestion" label to this issue to keep tracking suggestions from the community.

We will welcome more contributions for new models once we release our new modeling library for computer vision. We will share our roadmap with the community soon.

Please check our contribution guidelines for paper code for the time being.

@bhack
Copy link
Contributor

bhack commented May 14, 2020

@jaewoosong Are you closing the issues tagged as "community suggestion" or just this one?

@jaeyounkim
Copy link
Collaborator

jaeyounkim commented May 14, 2020

I am going to close all the issues labelled as "community suggestion" because I will be tracking "community suggestion" issues separately and review them monthly.

Feel free to reopen it if you have more suggestions.

@bhack
Copy link
Contributor

bhack commented May 14, 2020

If it is for an internal review plan it is ok but it could generate duplication cause I think that users will not check closed ticket so often.

@jaeyounkim
Copy link
Collaborator

@bhack I've created a new issue to list all requests for paper implementation. Please create a new issue if you want to request for other paper implementations after checking our model selection criteria.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
models:official models that come under official repository type:community request Requests from the community type:feature
Projects
None yet
Development

No branches or pull requests

5 participants