Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Design] Implement MPS ops under tfq.math #603

Closed
MichaelBroughton opened this issue Jul 8, 2021 · 1 comment · Fixed by #610
Closed

[Design] Implement MPS ops under tfq.math #603

MichaelBroughton opened this issue Jul 8, 2021 · 1 comment · Fixed by #610

Comments

@MichaelBroughton
Copy link
Collaborator

With PRs like:
quantumlib/qsim#374
and
quantumlib/qsim#372
going in, It makes sense for us to start looking into upgrading to the latest qsim so that we can add the MPS ops mentioned here. In particular I think we should have something like:

  1. tfq.math.1d_expectation
  2. tfq.math.1d_samples
  3. tfq.math.1d_sampled_expectation
    With C++ code very similar to what we already have in https://github.com/tensorflow/quantum/blob/master/tensorflow_quantum/core/ops/tfq_simulate_expectation_op.cc (except with additional error checking to ensure the circuit is 1d and using the MPSSimulator from qsim etc.)
@jaeyoo
Copy link
Member

jaeyoo commented Aug 3, 2021

I am just curious, may I add mps_ prefix for all three ops because names can't start with numbers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants