Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable tests on Windows #64

Open
tlemo opened this issue Jun 25, 2021 · 1 comment
Open

Enable tests on Windows #64

tlemo opened this issue Jun 25, 2021 · 1 comment
Assignees
Labels
windows Issues and changes related to Windows support

Comments

@tlemo
Copy link
Contributor

tlemo commented Jun 25, 2021

Currently, the scaffolding used to run the tests is not working on Windows

@tlemo tlemo added the windows Issues and changes related to Windows support label Jun 25, 2021
@tlemo tlemo self-assigned this Jun 25, 2021
@tlemo
Copy link
Contributor Author

tlemo commented Jul 20, 2021

I think I have most of the changes required to enable tests on Windows, but there're an unfortunate bump - an amusing MSVC++ bug:

tf_runtime\external\llvm-project\mlir\include\mlir/IR/Location.h(120): error C2440: 'reinterpret_cast': cannot convert from 'T' to 'uintptr_t'
        with
        [
            T=uintptr_t
        ]
tf_runtime\external\llvm-project\mlir\include\mlir/IR/Location.h(120): note: Conversion is a valid standard conversion, which can be performed implicitly or by use of static_cast, C-style cast or function-style cast
cpp_tests/bef_converter/bef_location_emitter_test.cc(56): note: see reference to function template instantiation 'mlir::Location mlir::OpaqueLoc::get<uintptr_t>(T,mlir::MLIRContext *)' being compiled
        with
        [
            T=uintptr_t
        ]

https://developercommunity.visualstudio.com/t/Bogus-C2440-involving-reinterpret_cast-w/1480040

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
windows Issues and changes related to Windows support
Projects
None yet
Development

No branches or pull requests

1 participant