Skip to content

Commit 045cab5

Browse files
committed
layout: make resizer smaller
Previously, we used to have a little icon and thick vertical bar to make resize affordance apparent on the left pane resizer. After surveying modern apps, it looks like they are often done with pointer in combination with thicker vertical bar on hover so we adopt those designs. In the end, with this change, we give users about 18 pixels back in the horizontal space.
1 parent a569150 commit 045cab5

File tree

2 files changed

+14
-6
lines changed

2 files changed

+14
-6
lines changed

tensorboard/webapp/core/views/layout_container.scss

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,22 +30,32 @@ limitations under the License.
3030
.expand {
3131
@include tb-theme-foreground-prop(border-color, border);
3232
box-sizing: border-box;
33-
flex: 0 0 20px;
33+
flex: 0 0;
3434
justify-self: stretch;
35-
width: 20px;
3635
}
3736

3837
.resizer {
3938
align-items: center;
4039
border-style: solid;
41-
border-width: 0 1px;
40+
border-width: 0 2px;
4241
cursor: ew-resize;
4342
display: flex;
4443
justify-self: stretch;
4544

4645
.mat-icon {
4746
width: 100%;
4847
}
48+
49+
&:hover {
50+
border-color: #ccc;
51+
outline: 3px solid #ccc;
52+
z-index: 1;
53+
54+
@include tb-dark-theme {
55+
outline-color: #777;
56+
border-color: #777;
57+
}
58+
}
4959
}
5060

5161
.expand {

tensorboard/webapp/core/views/layout_container.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,9 +49,7 @@ import {MouseEventButtons} from '../../util/dom';
4949
*ngIf="(width$ | async) > 0"
5050
class="resizer"
5151
(mousedown)="resizeGrabbed()"
52-
>
53-
<mat-icon svgIcon="drag_indicator_24px"></mat-icon>
54-
</div>
52+
></div>
5553
<ng-content select="[main]"></ng-content>
5654
`,
5755
styleUrls: ['layout_container.css'],

0 commit comments

Comments
 (0)