Skip to content

Commit 3f89dd0

Browse files
committed
update icon sizing to use width and height rather than a single variable
1 parent d32bf41 commit 3f89dd0

File tree

3 files changed

+32
-31
lines changed

3 files changed

+32
-31
lines changed

tensorboard/webapp/theme/_tb_theme.template.scss

Lines changed: 28 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -308,38 +308,37 @@ $tb-dark-theme: map_merge(
308308
--mdc-slider-inactive-track-height: 2px;
309309
}
310310

311-
::ng-deep :not(mat-calendar) {
312-
a,
313-
button.mat-mdc-button-base {
314-
--tb-icon-size: 24px;
315-
--mdc-text-button-label-text-tracking: normal;
316-
--mdc-filled-button-label-text-tracking: normal;
317-
--mdc-outlined-button-label-text-tracking: normal;
318-
--mdc-protected-button-label-text-tracking: normal;
319-
320-
&[mat-icon-button].mat-mdc-icon-button {
321-
width: 40px;
322-
height: 40px;
323-
display: inline-flex;
324-
justify-content: center;
325-
align-items: center;
326-
327-
.mat-mdc-button-touch-target {
328-
height: 100%;
329-
width: 100%;
330-
}
311+
a,
312+
button.mat-mdc-button-base {
313+
--tb-icon-width: 24px;
314+
--tb-icon-height: 24px;
315+
--mdc-text-button-label-text-tracking: normal;
316+
--mdc-filled-button-label-text-tracking: normal;
317+
--mdc-outlined-button-label-text-tracking: normal;
318+
--mdc-protected-button-label-text-tracking: normal;
319+
320+
&[mat-icon-button].mat-mdc-icon-button {
321+
width: 40px;
322+
height: 40px;
323+
display: inline-flex;
324+
justify-content: center;
325+
align-items: center;
326+
327+
.mat-mdc-button-touch-target {
328+
height: 100%;
329+
width: 100%;
331330
}
331+
}
332332

333-
mat-icon.mat-icon {
334-
flex-shrink: 0;
335-
}
333+
mat-icon.mat-icon {
334+
flex-shrink: 0;
335+
}
336336

337-
mat-icon.mat-icon,
338-
svg {
339-
width: var(--tb-icon-size);
340-
height: var(--tb-icon-size);
341-
line-height: var(--tb-icon-size);
342-
}
337+
mat-icon.mat-icon,
338+
svg {
339+
width: var(--tb-icon-width);
340+
height: var(--tb-icon-height);
341+
line-height: var(--tb-icon-height);
343342
}
344343
}
345344
}

tensorboard/webapp/widgets/data_table/header_cell_component.scss

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,8 @@ $_icon_padding: 4px;
5555
&.context-menu-container {
5656
width: $_icon_size + $_icon_padding;
5757
height: $_icon_size + $_icon_padding;
58-
--tb-icon-size: #{$_icon_size};
58+
--tb-icon-width: #{$_icon_size};
59+
--tb-icon-height: #{$_icon_size};
5960
border-radius: 5px;
6061
font-size: 12px;
6162
padding: $_icon_padding;

tensorboard/webapp/widgets/line_chart_v2/sub_view/line_chart_axis_view.scss

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,8 @@ text {
3434
width: 100%;
3535

3636
.extent-edit-button {
37-
--tb-icon-size: 16px;
37+
--tb-icon-width: 16px;
38+
--tb-icon-height: 16px;
3839
height: 24px;
3940
position: absolute;
4041
right: 5px;

0 commit comments

Comments
 (0)