Skip to content

Commit 9784a65

Browse files
authored
MDCMigration: Style runs data table column selector for MDC migration. (#6617)
Restyle the runs data table column selector. The contents end up being larger than current master version. The search icon, and search text input are bigger. The height of each item in the list is taller to match the larger button touch target. Some sample screenshots: ![image](https://github.com/tensorflow/tensorboard/assets/17152369/fb8e2f5e-3170-4222-b356-58c333cdcb57) ![image](https://github.com/tensorflow/tensorboard/assets/17152369/47b8aecb-3c1f-4615-a968-7564b2f93bd7)
1 parent 21bef1b commit 9784a65

File tree

2 files changed

+6
-10
lines changed

2 files changed

+6
-10
lines changed

tensorboard/webapp/widgets/data_table/column_selector_component.ng.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,11 @@
1414
<div class="contents">
1515
<mat-form-field class="search-area">
1616
<mat-icon matPrefix class="search-icon" svgIcon="search_24px"></mat-icon>
17+
<mat-label>Search</mat-label>
1718
<input
1819
matInput
1920
#search
2021
[(ngModel)]="searchInput"
21-
placeholder="Search"
2222
(ngModelChange)="searchInputChanged()"
2323
/>
2424
</mat-form-field>

tensorboard/webapp/widgets/data_table/column_selector_component.scss

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -38,14 +38,6 @@ limitations under the License.
3838

3939
.search-area {
4040
margin-bottom: 4px;
41-
42-
mat-icon.search-icon {
43-
font-size: 1em;
44-
45-
::ng-deep svg {
46-
padding-top: 6px;
47-
}
48-
}
4941
}
5042

5143
.column-list {
@@ -58,7 +50,11 @@ limitations under the License.
5850
}
5951

6052
.column-button {
61-
text-align: left;
53+
// Don't allow buttons to shrink when there are many of them.
54+
flex-shrink: 0;
55+
// Match height of button touch target to avoid unnecessary scrollbar.
56+
height: 48px;
57+
justify-content: left;
6258
width: 100%;
6359

6460
&.selected {

0 commit comments

Comments
 (0)