Skip to content

Commit ab906b2

Browse files
committed
MDCMigration: Style run table and right pane checkboxes for MDC
migration.
1 parent be5cc5c commit ab906b2

File tree

3 files changed

+20
-11
lines changed

3 files changed

+20
-11
lines changed

tensorboard/webapp/metrics/views/right_pane/settings_view_component.scss

Lines changed: 19 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,10 @@ section {
3434
margin: 0 0 12px 0;
3535
}
3636

37-
section .control-row:not(:last-child) {
37+
// Add additional margin between most control elements. The exception is when
38+
// the second control row is a checkbox, in which case we just rely on the
39+
// padding that is already included in the checkbox.
40+
section .control-row:not(:has(+ .control-row > mat-checkbox)):not(:last-child) {
3841
margin-bottom: 12px;
3942
}
4043

@@ -89,6 +92,20 @@ section .control-row:not(:last-child) {
8992
}
9093
}
9194

95+
mat-checkbox {
96+
// Counteract the padding of the checkbox in order to align it vertically
97+
// with other items in the pane.
98+
margin-left: -11px;
99+
100+
::ng-deep label {
101+
@include tb-theme-foreground-prop(color, secondary-text);
102+
font-size: 12px;
103+
letter-spacing: normal;
104+
padding-left: 0px;
105+
white-space: nowrap;
106+
}
107+
}
108+
92109
mat-slider {
93110
flex: 1;
94111
// Reset mat-slider's internal extra space on left/right sides
@@ -125,12 +142,8 @@ tb-dropdown {
125142
display: block;
126143
}
127144

128-
.linked-time {
129-
padding: 5px 0;
130-
}
131-
132145
.control-row {
133146
.indent {
134-
margin-left: 25px;
147+
margin-left: 28px;
135148
}
136149
}

tensorboard/webapp/runs/views/runs_table/runs_data_table.scss

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -56,10 +56,6 @@ tb-data-table-header-cell {
5656
vertical-align: middle;
5757
@include tb-theme-foreground-prop(border-bottom, border, 1px solid);
5858

59-
&:first-child {
60-
padding-left: 16px;
61-
}
62-
6359
&:last-child {
6460
@include tb-theme-foreground-prop(border-right, border, 1px solid);
6561
}

tensorboard/webapp/widgets/data_table/header_cell_component.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ $_icon_size: 12px;
2121

2222
:host {
2323
display: table-cell;
24-
padding: 2px;
24+
padding: 4px;
2525
vertical-align: bottom;
2626

2727
&:hover {

0 commit comments

Comments
 (0)