add some test cases to make test robust

Author: roseayeon

tensorboard/webapp/metrics/effects/index.ts

@@ -333,7 +333,7 @@ export class MetricsEffects implements OnInitEffects {
     })
   );
 
-  private readonly removeAllPins$ = this.actions$.pipe(
+  private readonly removeSavedPinsOnDisable$ = this.actions$.pipe(
     ofType(actions.metricsClearAllPinnedCards),
     withLatestFrom(
       this.store.select(selectors.getEnableGlobalPins),
@@ -423,11 +423,7 @@ export class MetricsEffects implements OnInitEffects {
         /**
          * Subscribes to: metricsClearAllPinnedCards.
          */
-        this.removeAllPins$,
-        /**
-         * Subscribes to: metricsEnableSavingPinsToggled.
-         */
-        this.disableSavingPins$
+        this.removeSavedPinsOnDisable$
       );
     },
     {dispatch: false}

tensorboard/webapp/metrics/store/metrics_reducers_test.ts

@@ -1234,18 +1234,22 @@ describe('metrics reducers', () => {
     });
 
     it('changes savingPinsEnabled on metricsEnableSavingPinsToggled', () => {
-      const prevState = buildMetricsState({
-        settings: buildMetricsSettingsState({
-          savingPinsEnabled: true,
-        }),
-        settingOverrides: {},
+      [{value: true}, {value: false}].forEach(({value: initValue}) => {
+        const prevState = buildMetricsState({
+          settings: buildMetricsSettingsState({
+            savingPinsEnabled: initValue,
+          }),
+          settingOverrides: {},
+        });
+
+        const nextState = reducers(
+          prevState,
+          actions.metricsEnableSavingPinsToggled()
+        );
+
+        expect(nextState.settings.savingPinsEnabled).toBe(initValue);
+        expect(nextState.settingOverrides.savingPinsEnabled).toBe(!initValue);
       });
-      const nextState = reducers(
-        prevState,
-        actions.metricsEnableSavingPinsToggled()
-      );
-      expect(nextState.settings.savingPinsEnabled).toBe(true);
-      expect(nextState.settingOverrides.savingPinsEnabled).toBe(false);
     });
   });
 

tensorboard/webapp/metrics/store/metrics_selectors_test.ts

@@ -1300,15 +1300,17 @@ describe('metrics selectors', () => {
     });
 
     it('returns savingPinsEnabled when called getMetricsSavingPinsEnabled', () => {
-      selectors.getMetricsSavingPinsEnabled.release();
-      const state = appStateFromMetricsState(
-        buildMetricsState({
-          settings: buildMetricsSettingsState({
-            savingPinsEnabled: false,
-          }),
-        })
-      );
-      expect(selectors.getMetricsSavingPinsEnabled(state)).toBe(false);
+      [{value: true}, {value: false}].forEach(({value}) => {
+        selectors.getMetricsSavingPinsEnabled.release();
+        const state = appStateFromMetricsState(
+          buildMetricsState({
+            settings: buildMetricsSettingsState({
+              savingPinsEnabled: value,
+            }),
+          })
+        );
+        expect(selectors.getMetricsSavingPinsEnabled(state)).toBe(value);
+      });
     });
   });