Skip to content

Commit c2bbc01

Browse files
stephanwleenfelt
authored andcommitted
Convert BaseResponse to wrappers.BaseResponse (#3230)
Although the werkzeug changelog did not say so, it seem to have removed certain symbols from `werkzeug`. We now use `werkzeug.wrappers.BaseResponse` instead. This is a cherry-pick of f833b39 to avoid black reformatting. Context: https://werkzeug.palletsprojects.com/en/master/changes/#version-1-0-0
1 parent 7157596 commit c2bbc01

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

tensorboard/backend/empty_path_redirect_test.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ def setUp(self):
3636
app = empty_path_redirect.EmptyPathRedirectMiddleware(app)
3737
app = self._lax_strip_foo_middleware(app)
3838
self.app = app
39-
self.server = werkzeug_test.Client(self.app, werkzeug.BaseResponse)
39+
self.server = werkzeug_test.Client(self.app, werkzeug.wrappers.BaseResponse)
4040

4141
def _lax_strip_foo_middleware(self, app):
4242
"""Strips a `/foo` prefix if it exists; no-op otherwise."""

tensorboard/backend/experiment_id_test.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ class ExperimentIdMiddlewareTest(tb_test.TestCase):
3333
def setUp(self):
3434
super(ExperimentIdMiddlewareTest, self).setUp()
3535
self.app = experiment_id.ExperimentIdMiddleware(self._echo_app)
36-
self.server = werkzeug_test.Client(self.app, werkzeug.BaseResponse)
36+
self.server = werkzeug_test.Client(self.app, werkzeug.wrappers.BaseResponse)
3737

3838
def _echo_app(self, environ, start_response):
3939
# https://www.python.org/dev/peps/pep-0333/#environ-variables

tensorboard/backend/path_prefix_test.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ def test_bad_path_prefix_with_trailing_slash(self):
6363

6464
def test_empty_path_prefix(self):
6565
app = path_prefix.PathPrefixMiddleware(self._echo_app, "")
66-
server = werkzeug_test.Client(app, werkzeug.BaseResponse)
66+
server = werkzeug_test.Client(app, werkzeug.wrappers.BaseResponse)
6767

6868
with self.subTest("at empty"):
6969
self._assert_ok(server.get(""), path="", script="")
@@ -77,7 +77,7 @@ def test_empty_path_prefix(self):
7777

7878
def test_nonempty_path_prefix(self):
7979
app = path_prefix.PathPrefixMiddleware(self._echo_app, "/pfx")
80-
server = werkzeug_test.Client(app, werkzeug.BaseResponse)
80+
server = werkzeug_test.Client(app, werkzeug.wrappers.BaseResponse)
8181

8282
with self.subTest("at root"):
8383
response = server.get("/pfx")
@@ -103,7 +103,7 @@ def test_composition(self):
103103
app = self._echo_app
104104
app = path_prefix.PathPrefixMiddleware(app, "/bar")
105105
app = path_prefix.PathPrefixMiddleware(app, "/foo")
106-
server = werkzeug_test.Client(app, werkzeug.BaseResponse)
106+
server = werkzeug_test.Client(app, werkzeug.wrappers.BaseResponse)
107107

108108
response = server.get("/foo/bar/baz/quux")
109109
self._assert_ok(response, path="/baz/quux", script="/foo/bar")

0 commit comments

Comments
 (0)