fix bug with run selection

Author: rileyajones

tensorboard/webapp/metrics/views/card_renderer/scalar_card_container.ts

@@ -56,6 +56,7 @@ import {
   getMetricsCardRangeSelectionEnabled,
   getRun,
   getRunColorMap,
+  getCurrentRouteRunSelection,
 } from '../../../selectors';
 import {DataLoadState} from '../../../types/data';
 import {
@@ -499,6 +500,7 @@ export class ScalarCardContainer implements CardRenderer, OnInit, OnDestroy {
         );
       }),
       combineLatestWith(
+        this.store.select(getCurrentRouteRunSelection),
         this.store.select(getFilteredRenderableRunsIdsFromRoute),
         this.store.select(getRunColorMap),
         this.store.select(getMetricsScalarSmoothing)
@@ -508,55 +510,67 @@ export class ScalarCardContainer implements CardRenderer, OnInit, OnDestroy {
       // debounce by a microtask to emit only single change for the runs
       // store change.
       debounceTime(0),
-      map(([namedPartitionedSeries, renderableRuns, colorMap, smoothing]) => {
-        const metadataMap: ScalarCardSeriesMetadataMap = {};
-        const shouldSmooth = smoothing > 0;
+      map(
+        ([
+          namedPartitionedSeries,
+          runSelectionMap,
+          renderableRuns,
+          colorMap,
+          smoothing,
+        ]) => {
+          const metadataMap: ScalarCardSeriesMetadataMap = {};
+          const shouldSmooth = smoothing > 0;
+
+          for (const partitioned of namedPartitionedSeries) {
+            const {
+              seriesId,
+              runId,
+              displayName,
+              alias,
+              partitionIndex,
+              partitionSize,
+            } = partitioned;
+
+            metadataMap[seriesId] = {
+              type: SeriesType.ORIGINAL,
+              id: seriesId,
+              alias,
+              displayName:
+                partitionSize > 1
+                  ? `${displayName}: ${partitionIndex}`
+                  : displayName,
+              visible: Boolean(
+                runSelectionMap &&
+                  runSelectionMap.get(runId) &&
+                  renderableRuns.has(runId)
+              ),
+              color: colorMap[runId] ?? '#fff',
+              aux: false,
+              opacity: 1,
+            };
+          }
+
+          if (!shouldSmooth) {
+            return metadataMap;
+          }
+
+          for (const [id, metadata] of Object.entries(metadataMap)) {
+            const smoothedSeriesId = getSmoothedSeriesId(id);
+            metadataMap[smoothedSeriesId] = {
+              ...metadata,
+              id: smoothedSeriesId,
+              type: SeriesType.DERIVED,
+              aux: false,
+              originalSeriesId: id,
+            };
 
-        for (const partitioned of namedPartitionedSeries) {
-          const {
-            seriesId,
-            runId,
-            displayName,
-            alias,
-            partitionIndex,
-            partitionSize,
-          } = partitioned;
-
-          metadataMap[seriesId] = {
-            type: SeriesType.ORIGINAL,
-            id: seriesId,
-            alias,
-            displayName:
-              partitionSize > 1
-                ? `${displayName}: ${partitionIndex}`
-                : displayName,
-            visible: Boolean(renderableRuns.has(runId)),
-            color: colorMap[runId] ?? '#fff',
-            aux: false,
-            opacity: 1,
-          };
-        }
+            metadata.aux = true;
+            metadata.opacity = 0.25;
+          }
 
-        if (!shouldSmooth) {
           return metadataMap;
         }
-
-        for (const [id, metadata] of Object.entries(metadataMap)) {
-          const smoothedSeriesId = getSmoothedSeriesId(id);
-          metadataMap[smoothedSeriesId] = {
-            ...metadata,
-            id: smoothedSeriesId,
-            type: SeriesType.DERIVED,
-            aux: false,
-            originalSeriesId: id,
-          };
-
-          metadata.aux = true;
-          metadata.opacity = 0.25;
-        }
-
-        return metadataMap;
-      }),
+      ),
       startWith({} as ScalarCardSeriesMetadataMap)
     );