Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for converting models with ImageProjectiveTransformV3 op. #6204

Closed
maciej3031 opened this issue Mar 7, 2022 · 2 comments
Closed
Assignees
Labels
type:feature New feature or request

Comments

@maciej3031
Copy link
Contributor

System information

  • TensorFlow.js version: 3.13.0
  • Are you willing to contribute it: Yes

Describe the feature and the current behavior/state.
tf.image.transform is not mapped with its tensorflow equivalent ImageProjectiveTransformV3 so if a model contains the ImageProjectiveTransformV3 then it cannot be converted to tfjs format easily. However, it seems that tf.image.transform is fully implemented and It only needs to be addressed in these files:

Will this change the current api? How?
It will only add the support for converting models with ImageProjectiveTransformV3.

Who will benefit with this feature?
Everyone who needs to convert a model that contains ImageProjectiveTransformV3 which is quite commonly used to apply affine transform to the tensor.

Any Other info.
I could implement it and create PR, but first I wanted to discuss it, is there any good reason that it is not implemented yet? Maybe I am missing something important?

@maciej3031 maciej3031 added the type:feature New feature or request label Mar 7, 2022
@lina128
Copy link
Collaborator

lina128 commented Mar 7, 2022

Sounds good to add the op support in converter. Looking forward to your PR, @maciej3031

@maciej3031
Copy link
Contributor Author

Hey @lina128, I created PR #6206. Please take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants