Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Behavior changes with latest XNNPack #7530

Open
chunnienc opened this issue Mar 29, 2023 · 0 comments
Open

Behavior changes with latest XNNPack #7530

chunnienc opened this issue Mar 29, 2023 · 0 comments
Assignees

Comments

@chunnienc
Copy link
Collaborator

The latest XNNPack updated by #7507 introduces some new checks in its ops. One of them is that average/max pooling ops now throws an error when input stride size is greater than the pooling size. The followings some sample error messages collected when running wasm backend test:

.Error in XNNPACK: failed to define Average Pooling (NHWC, F32) operator with 3 stride height: must be less than pooling height 2
Error in XNNPACK: failed to setup operator: operator type mismatch (expected Max Pooling (NHWC, F32), got Invalid)
WARN: 'Error in XNNPACK: failed to define Average Pooling (NHWC, F32) operator with 3 stride height: must be less than pooling height 2'
WARN: 'Error in XNNPACK: failed to define Max Pooling (NHWC, F32) operator with 3 stride height: must be less than pooling height'
WARN: 'Error in XNNPACK: failed to setup operator: operator type mismatch (expected Max Pooling (NHWC, F32), got Invalid)'

All the tests still pass since we do not check the values but only the tensor shapes in those cases. We should also check if other ops like conv2d has these new checks as well.

This issue is created to track the progress of the update.

@chunnienc chunnienc added the type:bug Something isn't working label Mar 29, 2023
@chunnienc chunnienc self-assigned this Mar 29, 2023
@chunnienc chunnienc added the RELEASE BLOCKER These issues must be resolved before the next release. label May 21, 2023
@chunnienc chunnienc removed the RELEASE BLOCKER These issues must be resolved before the next release. label Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants